Skip to content

BigQuery: Samples update and region tag standardization#5195

Merged
alixhami merged 2 commits into
googleapis:masterfrom
alixhami:bq-standardize-region-tags
Apr 13, 2018
Merged

BigQuery: Samples update and region tag standardization#5195
alixhami merged 2 commits into
googleapis:masterfrom
alixhami:bq-standardize-region-tags

Conversation

@alixhami
Copy link
Copy Markdown
Contributor

This PR accomplishes the following:

  • Updates non-standard region tags to the applicable standard
  • Standardizes commented out variables at the top of each sample with the intent that the sample can be copied and pasted and "just work" after uncommenting and customizing the variables
  • Deletes samples not used on cloud.google.com
  • Refactors samples that do not follow the canonical sample

@alixhami alixhami added documentation api: bigquery Issues related to the BigQuery API. labels Apr 13, 2018
@alixhami alixhami requested a review from tswast April 13, 2018 18:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2018
@alixhami alixhami force-pushed the bq-standardize-region-tags branch from d29c8f2 to a862bd6 Compare April 13, 2018 18:13
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple nits.

Comment thread docs/bigquery/snippets.py Outdated
# table_ref = client.dataset('my_dataset').table('my_table')
# table = client.get_table(table_ref) # API request

import datetime

This comment was marked as spam.

Comment thread docs/bigquery/snippets.py Outdated
to_delete.append(dataset)
snippets_directory = os.path.abspath(os.path.dirname(__file__))
filename = os.path.join(
snippets_directory, '../../bigquery/tests/data', 'people.csv')

This comment was marked as spam.

@alixhami alixhami merged commit 9c745f2 into googleapis:master Apr 13, 2018
@alixhami alixhami deleted the bq-standardize-region-tags branch April 13, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants