Skip to content

Multiprocessing warning in documentation#4834

Merged
chemelnucfin merged 2 commits into
googleapis:masterfrom
chemelnucfin:spanner_multiprocessing_warning_docs
Feb 22, 2018
Merged

Multiprocessing warning in documentation#4834
chemelnucfin merged 2 commits into
googleapis:masterfrom
chemelnucfin:spanner_multiprocessing_warning_docs

Conversation

@chemelnucfin
Copy link
Copy Markdown
Contributor

@vkedia Is this good for now? I will update it as I find out more information.

@chemelnucfin chemelnucfin added documentation api: spanner Issues related to the Spanner API. labels Feb 3, 2018
@chemelnucfin chemelnucfin self-assigned this Feb 3, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2018
@chemelnucfin chemelnucfin force-pushed the spanner_multiprocessing_warning_docs branch from 539f5c4 to 2667c6b Compare February 4, 2018 00:04
Comment thread docs/spanner/usage.rst Outdated

Warnings about Multithreading and Multiprocessing
-------------------------------------------------
- Multiprocessing has been known to hang if ``client`` creation is before fork()

This comment was marked as spam.

@chemelnucfin
Copy link
Copy Markdown
Contributor Author

@tseaver, PTAL, thanks.

Comment thread docs/spanner/usage.rst Outdated
The issue is under investigation, but may be only happening on Macintosh and not Linux.
See `GRPC/GRPC#12455 <https://github.com/grpc/grpc/issues/12455#issuecomment-348578950>`_ for more information.

- It is also possible that multithreading creates a segmentation fault, but may have

This comment was marked as spam.

@chemelnucfin chemelnucfin changed the title Spanner: multiprocessing warning in documentation Multiprocessing warning in documentation Feb 20, 2018
@chemelnucfin chemelnucfin added the type: process A process-related concern. May include testing, release, or the like. label Feb 20, 2018
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should drop the paragraph about multithreading.

@chemelnucfin chemelnucfin force-pushed the spanner_multiprocessing_warning_docs branch from fe285ea to 40ffe18 Compare February 22, 2018 21:36
@chemelnucfin chemelnucfin force-pushed the spanner_multiprocessing_warning_docs branch from 40ffe18 to e672916 Compare February 22, 2018 21:38
@chemelnucfin
Copy link
Copy Markdown
Contributor Author

I was waiting for more clarification on the multiprocessing issue to take care of both multiprocessing and multithreading.

Removed the multithreading. Merging. Will update on newer developments.

@chemelnucfin chemelnucfin merged commit db4c151 into googleapis:master Feb 22, 2018
@chemelnucfin chemelnucfin deleted the spanner_multiprocessing_warning_docs branch February 22, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants