Skip to content

clarify that modify_ack_deadline resets the deadline#4822

Merged
theacodes merged 2 commits intogoogleapis:masterfrom
opyate:issue-4648-pydoc-improvement
Feb 5, 2018
Merged

clarify that modify_ack_deadline resets the deadline#4822
theacodes merged 2 commits intogoogleapis:masterfrom
opyate:issue-4648-pydoc-improvement

Conversation

@opyate
Copy link
Copy Markdown
Contributor

@opyate opyate commented Feb 1, 2018

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 1, 2018
@opyate
Copy link
Copy Markdown
Contributor Author

opyate commented Feb 1, 2018

CLA signed.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 1, 2018
@theacodes
Copy link
Copy Markdown
Contributor

@kir-titievsky do you mind taking a look to see if this satisfies your request?

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 2, 2018
@tseaver tseaver added documentation api: pubsub Issues related to the Pub/Sub API. labels Feb 2, 2018
@kir-titievsky
Copy link
Copy Markdown

@jonparrott: lgtm.
@opyate Thank you!

@opyate
Copy link
Copy Markdown
Contributor Author

opyate commented Feb 2, 2018

@googlebot yes, I consent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants