Skip to content

Spanner: make to_pb private in keyset#4740

Merged
chemelnucfin merged 1 commit intogoogleapis:masterfrom
chemelnucfin:spanner_to_pb_private
Feb 5, 2018
Merged

Spanner: make to_pb private in keyset#4740
chemelnucfin merged 1 commit intogoogleapis:masterfrom
chemelnucfin:spanner_to_pb_private

Conversation

@chemelnucfin
Copy link
Copy Markdown
Contributor

@chemelnucfin chemelnucfin commented Jan 11, 2018

This might be considered a breaking change?
See #4710

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
@theacodes theacodes self-assigned this Jan 11, 2018
@theacodes theacodes self-requested a review January 11, 2018 20:19
@theacodes theacodes added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: spanner Issues related to the Spanner API. labels Jan 11, 2018
@theacodes
Copy link
Copy Markdown
Contributor

Let's wait on this until we get more details.

@chemelnucfin chemelnucfin added type: question Request for information or clarification. Not an issue. status: awaiting information labels Jan 15, 2018
@chemelnucfin chemelnucfin mentioned this pull request Feb 5, 2018
9 tasks
@chemelnucfin chemelnucfin force-pushed the spanner_to_pb_private branch from d56e7bb to b51ceab Compare February 5, 2018 22:02
@chemelnucfin chemelnucfin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 5, 2018
@chemelnucfin
Copy link
Copy Markdown
Contributor Author

@jonparrott merging because cover is missing on /gapic/ and /proto/ files. Let me know otherwise.

@chemelnucfin chemelnucfin merged commit 8a1dc59 into googleapis:master Feb 5, 2018
chemelnucfin added a commit to chemelnucfin/google-cloud-python that referenced this pull request Feb 8, 2018
parthea pushed a commit that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. status: awaiting information type: question Request for information or clarification. Not an issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants