Skip to content

Checking _Rendezvous.done() when stopping Pub / Sub request generator. - #4554

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:pubsub-check-rendez-done
Dec 7, 2017
Merged

dhermes merged 2 commits into
googleapis:masterfrom
dhermes:pubsub-check-rendez-done

Conversation

@dhermes

@dhermes dhermes commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Dec 7, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2017
Args:
request_generator (Generator): A streaming pull request generator
returned from :meth:`_request_generator_thread`.
response_generator (grpc._channel._Rendezvous): The gRPC

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes

dhermes commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

Updated docstring (no code changes). Merging without CI (since no code changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants