Repository navigation
Various hygiene changes to Pub / Sub subscriber. - #4494
Merged
Merged
Conversation
theacodes
approved these changes
Nov 29, 2017
- Using `%`-formatting in all `logging.log()` calls (e.g. `info()`). I am not opposed to using `.format()` but `logging` "prefers" `%`-formatting (and I wanted to be consistent because hobgoblins). - Adding non-public globals for helper thread names, this was especially needed because I accidentally broke this in googleapis#4476 when I changed `callback requests worker` to `CallbackRequestsWorker` in one place, not two. - Adding docstring to `QueueCallbackThread` that explains what it does (I'll refactor this class in a follow-up) - Adding a logging statement when a `QueueCallbackThread` exits - Changing indents / using much more vertical space in calls to `request_queue.put()` in `subscriber.message.Message`. (I came across these when trying to understand how `QueueCallbackThread` interacts with `Policy.on_callback_request`) - Changing `GPRC` to `gRPC` in a docstring - Moving "Creating callback requests thread (not starting)." until right before the resource is created - Changing "Spawning" to "Starting" in a log message to match others
dhermes
force-pushed
the
pubsub-style
branch
from
November 29, 2017 23:12
d672502 to
c340cd2
Compare
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
- Using `%`-formatting in all `logging.log()` calls (e.g. `info()`). I am not opposed to using `.format()` but `logging` "prefers" `%`-formatting (and I wanted to be consistent because hobgoblins). - Adding non-public globals for helper thread names, this was especially needed because I accidentally broke this in #4476 when I changed `callback requests worker` to `CallbackRequestsWorker` in one place, not two. - Adding docstring to `QueueCallbackThread` that explains what it does (I'll refactor this class in a follow-up) - Adding a logging statement when a `QueueCallbackThread` exits - Changing indents / using much more vertical space in calls to `request_queue.put()` in `subscriber.message.Message`. (I came across these when trying to understand how `QueueCallbackThread` interacts with `Policy.on_callback_request`) - Changing `GPRC` to `gRPC` in a docstring - Moving "Creating callback requests thread (not starting)." until right before the resource is created - Changing "Spawning" to "Starting" in a log message to match others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%-formatting in alllogging.log()calls (e.g.info()). I am not opposed to using.format()butlogging"prefers"%-formatting (and I wanted to be consistent because hobgoblins).callback requests workertoCallbackRequestsWorkerin one place, not two.QueueCallbackThreadthat explains what it does (I'll refactor this class in a follow-up)QueueCallbackThreadexitsrequest_queue.put()insubscriber.message.Message. (I came across these when trying to understand howQueueCallbackThreadinteracts withPolicy.on_callback_request)maintain_leasesexitsGPRCtogRPCin a docstringNOTE: Many of these can be construed as "nit picks" but I wanted to get them out of my staged changed while working on #4463.