Skip to content

Adding thread prefix for ThreadPoolExecutor in Pub/Sub. - #4480

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:pubsub-name-executor
Nov 30, 2017
Merged

dhermes merged 2 commits into
googleapis:masterfrom
dhermes:pubsub-name-executor

Conversation

@dhermes

@dhermes dhermes commented Nov 29, 2017

Copy link
Copy Markdown
Contributor

This is a follow-on to #4474 and #4476.

@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Nov 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2017
executor = futures.ThreadPoolExecutor(max_workers=10)
executor = futures.ThreadPoolExecutor(
max_workers=10,
thread_name_prefix='ThreadPoolExecutor-SubscriberPolicy',

This comment was marked as spam.

@dhermes

dhermes commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

This feature is not present in the concurrent.futures backport, but has been checked into their source tree (agronholm/pythonfutures#63).

@theacodes

Copy link
Copy Markdown
Contributor

This feature is not present in the concurrent.futures backport, but has been checked into their source tree (agronholm/pythonfutures#63).

great. Can we turn it on for Python 3 for now?

@dhermes

dhermes commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

@jonparrott We can, but the maintainer of the backport indicated he may do a release soon, so it might be worth waiting (if it's on the order of a day).

@dhermes
dhermes force-pushed the pubsub-name-executor branch from 51a5f0a to e81228d Compare November 30, 2017 00:12
@dhermes
dhermes merged commit 94617d8 into googleapis:master Nov 30, 2017
@dhermes
dhermes deleted the pubsub-name-executor branch November 30, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants