Repository navigation
fix(oauth2): validate Firebase issuer and warn on omitted audience in verify_firebase_token - #18777
Draft
macastelaz wants to merge 2 commits into
Draft
macastelaz wants to merge 2 commits into
macastelaz wants to merge 2 commits into
Conversation
…omitted in verify_firebase_token
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances security in both the synchronous and asynchronous implementations of verify_firebase_token by validating the token's audience (aud) and issuer (iss) claims. It also introduces a warning when the function is called without an audience, as this can be insecure. Comprehensive unit tests have been added to verify these validations and warnings. I have no additional feedback to provide as the changes are well-implemented and properly tested.
…ngs, and test coverage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates that the decoded Firebase ID token contains a non-empty 'aud' claim and that 'iss' matches 'https://securetoken.google.com/', and emits a UserWarning when 'audience' is omitted in verify_firebase_token().
Context: b/511890255