Repository navigation
fix(pubsub): complete publish futures on unexpected RPC errors - #18751
Open
maximilliangrand wants to merge 1 commit into
Open
maximilliangrand wants to merge 1 commit into
maximilliangrand wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the publisher batch commit thread to catch all exceptions instead of only specific API and transport errors. This ensures that any unexpected publishing errors are propagated to the futures, preventing callers from waiting indefinitely. Additionally, the unit tests have been updated to cover more exception types and to verify that invalid RPC options correctly fail and propagate exceptions. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the publish RPC raises an exception outside
GoogleAPIErrororTransportError, the batch thread exits with its futures still pending. For example,retry="invalid"raises aTypeErrorin the GAPIC wrapper, butfuture.result()waits indefinitely.Route ordinary publishing exceptions through the existing batch failure path so every future receives the original exception and the batch completion callback reports failure. This also covers credential refresh errors. Regression tests exercise the real threaded GAPIC wrapper with invalid retry/timeout values and verify the error state, callback, and exception identity for every future.
Fixes #15642.
Validation: