Repository navigation
feat(firestore): add x-goog-is-transaction routing header - #18749
Open
nikhilchowdary wants to merge 3 commits into
Open
nikhilchowdary wants to merge 3 commits into
nikhilchowdary wants to merge 3 commits into
Conversation
Add x-goog-is-transaction routing header in Python SDK to differentiate transactional requests and non-transactional requests from firestore. Having a routing header for transactions helps in routing grpc requests at GFE.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces transactional RPC metadata to the Firestore client, ensuring that RPC requests executed within a transaction include the x-goog-is-transaction header. This is achieved by updating the metadata helper, client classes, queries, and transaction managers to conditionally supply _transaction_rpc_metadata when a transaction is active. However, a critical issue was identified in pipeline_result.py where accessing self.transaction instead of the internal self._transaction attribute will raise an AttributeError at runtime in both the synchronous and asynchronous iterator implementations.
…line_result.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…line_result.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add x-goog-is-transaction routing header in Python SDK to differentiate transactional requests and non-transactional requests from firestore. Having a routing header for transactions helps in routing grpc requests at GFE.