Repository navigation
Conversation
… handshake secret
…ule-level import Change-Id: I533b2c7e1bb78ff725a74db5b00bb701a082b1df
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a security mechanism for the AcceleratorDaemon by generating a 256-bit URL-safe authentication secret upon startup and writing it to the daemon's stdin. The sync and async accelerator clients are updated to pass this secret as metadata (x-accelerator-token) in their RPC calls. Additionally, the client now handles _AcceleratorUnverified exceptions by falling back to the native client with a warning. Unit tests have been added to verify the secret generation and handling. Feedback suggests adding defensive checks to ensure self._proc and self._proc.stdin are initialized before writing to stdin, which would also allow the removal of type: ignore comments.
mutianf
removed this pull request from stack #18689
October 13, 2026 20:06
mutianf
added this pull request to stack #18691
October 13, 2026 20:07
Change-Id: I33e67c9868b186353eff3857406b62ffbfa97eb2
…se for explicit-mode Change-Id: I030357650201f8681a31d3135cbbff726a4aa650
…rror Change-Id: I8d4bf5acf04b72af47e6d65829b41d7d8d800165
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
Stack created with GitHub Stacks CLI • Give Feedback 💬