Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ExternalConfig to gracefully handle cases where sourceFormat is missing from the API representation. Specifically, it changes source_format retrieval to use .get() instead of direct dictionary access, updates the property's type hint and docstring to reflect that it can be Optional, and adds a unit test to verify this behavior. There are no review comments, and the changes look correct, so there is no feedback to provide.
ohmayr
approved these changes
Oct 12, 2026
ohmayr
deleted the
triage_bq_failover_routing_bigquery_fix-source-format_b564883082
branch
October 12, 2026 07:17
Merged
Contributor
|
NOTE: fixes internal bug: b/564883082 |
hj690
pushed a commit
that referenced
this pull request
Oct 15, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>db-dtypes: 1.8.0</summary> ## [1.8.0](db-dtypes-v1.7.2...db-dtypes-v1.8.0) (2026-10-15) ### Features * **db-dtypes:** support pandas 3.1 ([#18590](#18590)) ([f18a11e](f18a11e)) </details> <details><summary>gapic-generator: 1.43.1</summary> ## [1.43.1](gapic-generator-v1.43.0...gapic-generator-v1.43.1) (2026-10-15) ### Bug Fixes * **gapic-generator:** do not emit empty routing metadata on client-streaming RPCs ([#18591](#18591)) ([bbdd643](bbdd643)) * **gapic-generator:** resolve showcase-mypy incompatible redefinition ([7032a89](7032a89)) * **gapic-generator:** resolve showcase-mypy incompatible redefinition and add canary CI job ([#18701](#18701)) ([7032a89](7032a89)) </details> <details><summary>gcp-sphinx-docfx-yaml: 3.4.0</summary> ## [3.4.0](gcp-sphinx-docfx-yaml-v3.3.3...gcp-sphinx-docfx-yaml-v3.4.0) (2026-10-15) ### Features * **gcp-sphinx-docfx-yaml:** optimize performance ([#18588](#18588)) ([cf1a0e5](cf1a0e5)) </details> <details><summary>google-cloud-alloydb: 0.11.4</summary> ## [0.11.4](google-cloud-alloydb-v0.11.3...google-cloud-alloydb-v0.11.4) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-bigquery: 3.46.2</summary> ## [3.46.2](google-cloud-bigquery-v3.46.1...google-cloud-bigquery-v3.46.2) (2026-10-15) ### Bug Fixes * **bigquery:** accept empty sourceFormat fields ([#18472](#18472)) ([590e43d](590e43d)) * **bigquery:** drop startIndex whenever a page token is sent ([#18603](#18603)) ([fc6eae3](fc6eae3)) * **bigquery:** remove PendingDeprecationWarning from RowIterator.to_arrow ([#18684](#18684)) ([9025061](9025061)) </details> <details><summary>google-cloud-bigquery-storage: 2.43.0</summary> ## [2.43.0](google-cloud-bigquery-storage-v2.42.0...google-cloud-bigquery-storage-v2.43.0) (2026-10-15) ### Features * **bigquery-storage:** add Arrow options and cancel to read_rows ([#18643](#18643)) ([939bdd0](939bdd0)) </details> <details><summary>google-cloud-bigtable: 2.50.1</summary> ## [2.50.1](google-cloud-bigtable-v2.50.0...google-cloud-bigtable-v2.50.1) (2026-10-15) ### Bug Fixes * **bigtable:** avoid hang when batcher not closed on process exit ([#18610](#18610)) ([7674c91](7674c91)) * **bigtable:** fix authentication scopes for metrics exporter ([#18609](#18609)) ([722d34e](722d34e)) </details> <details><summary>google-cloud-build: 3.41.0</summary> ## [3.41.0](google-cloud-build-v3.40.0...google-cloud-build-v3.41.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-compute: 1.56.0</summary> ## [1.56.0](google-cloud-compute-v1.55.0...google-cloud-compute-v1.56.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-compute-v1beta: 0.12.9</summary> ## [0.12.9](google-cloud-compute-v1beta-v0.12.8...google-cloud-compute-v1beta-v0.12.9) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-contact-center-insights: 1.29.0</summary> ## [1.29.0](google-cloud-contact-center-insights-v1.28.0...google-cloud-contact-center-insights-v1.29.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-dataproc: 5.32.0</summary> ## [5.32.0](google-cloud-dataproc-v5.31.0...google-cloud-dataproc-v5.32.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-datastream: 1.21.0</summary> ## [1.21.0](google-cloud-datastream-v1.20.0...google-cloud-datastream-v1.21.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-memorystore: 0.5.6</summary> ## [0.5.6](google-cloud-memorystore-v0.5.5...google-cloud-memorystore-v0.5.6) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-pubsub: 2.43.0</summary> ## [2.43.0](google-cloud-pubsub-v2.42.0...google-cloud-pubsub-v2.43.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-redis-cluster: 0.5.5</summary> ## [0.5.5](google-cloud-redis-cluster-v0.5.4...google-cloud-redis-cluster-v0.5.5) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-securitycenter: 1.48.0</summary> ## [1.48.0](google-cloud-securitycenter-v1.47.0...google-cloud-securitycenter-v1.48.0) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> <details><summary>google-cloud-storage: 3.17.1</summary> ## [3.17.1](google-cloud-storage-v3.17.0...google-cloud-storage-v3.17.1) (2026-10-15) ### Bug Fixes * **storage:** set GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES=2 in benchmark runner ([#18703](#18703)) ([a9ca134](a9ca134)) </details> <details><summary>google-developer-knowledge: 0.1.5</summary> ## [0.1.5](google-developer-knowledge-v0.1.4...google-developer-knowledge-v0.1.5) (2026-10-15) ### Features * update API sources and regenerate ([#18699](#18699)) ([1aa57db](1aa57db)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumes sourceFormat will always be present. According to the spec, there are cases where it is expected to be ommitted.
This PR changes the code to return None in that case, rather than encounter a KeyError