Repository navigation
feat(crc32c): add Python 3.15 classifier - #18441
Conversation
Add the Python 3.15 classifier to setup.cfg and declare classifiers under dynamic in pyproject.toml so that setuptools includes the classifiers in built distribution metadata.
There was a problem hiding this comment.
Code Review
This pull request updates the package configuration for 'google-crc32c' by declaring 'classifiers' as dynamic in 'pyproject.toml' and adding a classifier for Python 3.15 in 'setup.cfg'. However, the Python 3.15 classifier is not yet supported by PyPI, which will cause package uploads to fail with a 400 Bad Request error. It is recommended to remove this classifier until Python 3.15 is officially supported.
| Programming Language :: Python :: 3.12 | ||
| Programming Language :: Python :: 3.13 | ||
| Programming Language :: Python :: 3.14 | ||
| Programming Language :: Python :: 3.15 |
There was a problem hiding this comment.
The classifier Programming Language :: Python :: 3.15 is not yet supported or recognized by PyPI. Attempting to upload a package with an unrecognized classifier will cause PyPI to reject the release with a 400 Bad Request error. Please remove this classifier until Python 3.15 is officially supported and the classifier is added to PyPI's allowed list.
There was a problem hiding this comment.
This seems to be out of date, I see it on their list: https://pypi.org/classifiers/
Context & Problem
Python 3.15 support was recently added to wheel builds and Nox test suites for google-crc32c, but the package metadata was missing the Python 3.15 classifier and setuptools was omitting classifiers due to pyproject.toml configuration.
Summary of Changes
Programming Language :: Python :: 3.15tosetup.cfgunder classifiers.dynamic = ["classifiers"].Verification
nox -s unit-3.15with 100% test coverage (60/60statements,10/10branches).nox -s coververifying 100% coverage threshold.nox -s lint format lint_setup_pywith all checks passing.METADATA) to confirm all classifiers including Python 3.15 are emitted.Towards #17741
BEGIN_COMMIT_OVERRIDE
feat(crc32c): add Python 3.15 classifier
Release-As: 1.9.0rc0
END_COMMIT_OVERRIDE