tests(functions): add flaky retries for apply axis 1 tests - #18109
Open
shuoweil wants to merge 1 commit into
Open
tests(functions): add flaky retries for apply axis 1 tests#18109shuoweil wants to merge 1 commit into
shuoweil wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds @pytest.mark.flaky decorators to several system tests in test_managed_function.py and test_remote_function.py to mitigate test flakiness by configuring retries and delays. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tests/system/large/functions/test_managed_function.pyandtests/system/large/functions/test_remote_function.py, tests exercisingDataFrame.apply(axis=1)deploy ephemeral Cloud Functions and BigQuery remote connection assets.Under parallel CI execution (
pytest -n 20), concurrent function deployment requests occasionally hit transient Cloud Functions deployment rate limiting or IAM propagation delays.Changes
@pytest.mark.flaky(retries=2, delay=120)totest_df_apply_axis_1_multiple_params,test_df_apply_axis_1_multiple_params_array_output, andtest_df_apply_axis_1_single_param_non_seriesintest_remote_function.py.@pytest.mark.flaky(retries=2, delay=30)totest_managed_function_dataframe_apply_axis_1_array_outputandtest_managed_function_df_apply_axis_1intest_managed_function.py.Fixes #<545713683> 🦕