feat(google/cloud/ftp/v1): add google-cloud-ftp - #18104
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the new google-cloud-ftp Python client library, including its generated GAPIC client, documentation, samples, and testing configurations. The review identified critical issues with non-existent dependency versions specified in the configuration files: grpcio is pinned to a non-existent version 1.75.1 in both setup.py and noxfile.py, and ruff is pinned to a non-existent version 0.14.14 in noxfile.py. These invalid versions must be updated to valid, existing PyPI releases to prevent installation and testing failures.
| # See https://github.com/googleapis/google-cloud-python/issues/12364 | ||
| "google-auth >= 2.14.1, <3.0.0,!=2.24.0,!=2.25.0", | ||
| "grpcio >= 1.59.0, < 2.0.0", | ||
| "grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'", |
There was a problem hiding this comment.
The version 1.75.1 of grpcio does not exist on PyPI. Specifying a non-existent version will cause installation failures. Please update it to a valid version like 1.65.1.
| "grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'", | |
| "grpcio >= 1.65.1, < 2.0.0", |
References
- When defining dependency constraints in setup.py, ensure they align with the released gapic-generator templates and do not add redundant environment markers.
|
|
||
| import nox | ||
|
|
||
| RUFF_VERSION = "ruff==0.14.14" |
There was a problem hiding this comment.
The version 0.14.14 of ruff does not exist on PyPI. Specifying a non-existent version will cause nox to fail when setting up the linting and formatting environments. Please update it to a valid version like 0.4.14.
| RUFF_VERSION = "ruff==0.14.14" | |
| RUFF_VERSION = "ruff==0.4.14" |
|
|
||
| def install_systemtest_dependencies(session, *constraints): | ||
| if session.python >= "3.12": | ||
| session.install("--pre", "grpcio>=1.75.1") |
There was a problem hiding this comment.
The version 1.75.1 of grpcio does not exist on PyPI. This will cause the unit test session to fail on Python 3.12+ because pip cannot find a matching version. Please update it to a valid version like 1.65.1.
| session.install("--pre", "grpcio>=1.75.1") | |
| session.install("--pre", "grpcio>=1.65.1") |
b/543713113
PiperOrigin-RevId: 960764304