fix(ml): isolate temporary model names in LLM system tests - #18095
Open
shuoweil wants to merge 4 commits into
Open
fix(ml): isolate temporary model names in LLM system tests#18095shuoweil wants to merge 4 commits into
shuoweil wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the LLM system tests in 'packages/bigframes/tests/system/large/ml/test_llm.py' to sanitize model names by replacing hyphens and periods with underscores when constructing BigQuery model names. The review feedback recommends also replacing the '@' character with an underscore, as Vertex AI model names often contain '@' (e.g., 'textembedding-gecko@001'), which would otherwise cause BigQuery API errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tests/system/large/ml/test_llm.py, parameterized test cases forGeminiTextGeneratorandTextEmbeddingGeneratorwere saving models to BigQuery using the same hardcoded model name (temp_text_model).When running system tests in parallel (
pytest-xdist), concurrent workers overwrite each other's models in the shared dataset, resulting in race conditions and test failures.Changes
test_create_load_gemini_text_generator_modelandtest_create_load_text_embedding_generator_modelto include the sanitized model name in the temporary BigQuery model ID.Fixes #<545715319> 🦕