feat: check python and dependency versions in bigquery and ndb - #18075
Open
ohmayr wants to merge 1 commit into
Open
feat: check python and dependency versions in bigquery and ndb#18075ohmayr wants to merge 1 commit into
ohmayr wants to merge 1 commit into
Conversation
ohmayr
force-pushed
the
feat/handwritten-pqc-deprecation-warning
branch
from
August 11, 2026 19:08
dcae2d5 to
3e9304a
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds Python version and dependency version checks using google.api_core during the initialization of the google-cloud-bigquery and google-cloud-ndb packages. There are no review comments, and I have no feedback to provide.
ohmayr
force-pushed
the
feat/handwritten-pqc-deprecation-warning
branch
from
August 11, 2026 19:10
3e9304a to
402b8da
Compare
daniel-sanche
approved these changes
Aug 11, 2026
shuoweil
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
check_python_version(__name__)andcheck_dependency_versions(__name__)togoogle.cloud.bigqueryandgoogle.cloud.ndbat package import time.This establishes parity with the standard GAPIC-generated packages across the repository and ensures deprecation notices (such as Python version deprecations and upcoming
grpcio >= 1.83.0PQC requirements) are consistently emitted when these packages are imported.Towards: b/537446703