Skip to content

fix(generator): switch core_deps_from_source to DEFAULT_PYTHON_VERSION #18050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 5 commits into from
Aug 12, 2026
Merged

fix(generator): switch core_deps_from_source to DEFAULT_PYTHON_VERSION #18050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44db805
chore(generator): run prerelease_deps and core_deps_from_source on DE…
ohmayr Aug 10, 2026
92f9a43
update workflow
ohmayr Aug 10, 2026
99e40ee
revert prerelease
ohmayr Aug 11, 2026
e6c652f
revert workflow
ohmayr Aug 11, 2026
9cc9e8c
update workflow
ohmayr Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gapic-generator-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
pip install nox
cd packages/gapic-generator
for pkg in credentials eventarc logging redis; do
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${LATEST_STABLE_PYTHON}
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${LATEST_STABLE_PYTHON} core_deps_from_source
done
# Run pylint (errors-only) over the goldens so generator regressions
# like undefined names or import-time breakage that ruff/flake8 do
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
pip install nox
cd packages/gapic-generator
for pkg in credentials eventarc logging redis; do
nox -f tests/integration/goldens/$pkg/noxfile.py -s core_deps_from_source prerelease_deps
nox -f tests/integration/goldens/$pkg/noxfile.py -s prerelease_deps
done

fragment-snippet:
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/gapic/templates/noxfile.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/asset/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/credentials/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/eventarc/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/logging_internal/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/redis/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/redis_selective/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
2 changes: 1 addition & 1 deletion packages/gapic-generator/tests/integration/goldens/storagebatchoperations/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
)


@nox.session(python=PREVIEW_PYTHON_VERSION)
@nox.session(python=DEFAULT_PYTHON_VERSION)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
Expand Down
Loading