feat(bigquery-storage): add deprecation warning for to_dataframe - #18022
Open
shuoweil wants to merge 1 commit into
Open
feat(bigquery-storage): add deprecation warning for to_dataframe#18022shuoweil wants to merge 1 commit into
shuoweil wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a PendingDeprecationWarning to the to_dataframe method in reader.py to notify users that retrieving DataFrames directly via google-cloud-bigquery-storage is deprecated, suggesting alternatives like pandas_gbq. It also adds a unit test to verify that this warning is emitted correctly. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the addition of
PendingDeprecationWarningtoReadRowsPage.to_arrow()in #17938, this PR addsPendingDeprecationWarningtoReadRowsPage.to_dataframe()ingoogle-cloud-bigquery-storage.This notifies developers to adopt direct
pandas-gbqAPIs (pandas_gbq.read_gbq()orpandas_gbq.pandas.read_bigquery_stream_batches()) ahead of future deprecation phases.Fixes #< 526614511 > 🦕