fix(oauth2): avoid redundant JWKS network fetches#17891
Open
macastelaz wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ID token verification to use PyJWKSet.from_dict and get_unverified_header from pyjwt instead of PyJWKClient. However, PyJWKSet does not support subscripting, which will cause a runtime TypeError when attempting to retrieve the signing key. The reviewer recommends iterating over jwkset.keys to find the matching key ID and updating the corresponding unit tests to mock this behavior.
macastelaz
force-pushed
the
fix-jwks-double-fetch
branch
from
July 24, 2026 02:17
a1155ce to
1b7f57a
Compare
Addresses a performance regression resulting in duplicate fetches of the JWKS endpoint by utilizing the already-fetched certs payload via PyJWKSet.from_dict instead of deferring to PyJWKClient.
macastelaz
force-pushed
the
fix-jwks-double-fetch
branch
from
July 24, 2026 02:24
1b7f57a to
0087e24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a performance regression resulting in duplicate fetches of the JWKS endpoint by utilizing the already-fetched certs payload via PyJWKSet.from_dict instead of deferring to PyJWKClient.