chore(generator): add compatability layer templates#17886
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a compatibility module (_compat.py) and its corresponding unit tests (test_compat.py) to the GAPIC generator templates, updating the generator to allow these private templates and prevent them from being skipped when empty. The review feedback correctly identifies that prepending # before the license include statement in the template files results in double comment characters (# #) in the generated golden files, and suggests removing the leading # to fix this formatting issue.
hebaalazzeh
force-pushed
the
compact-layer
branch
from
July 23, 2026 22:18
fc1ec0a to
ed908a3
Compare
hebaalazzeh
marked this pull request as ready for review
July 23, 2026 22:18
hebaalazzeh
force-pushed
the
compact-layer
branch
from
July 23, 2026 22:44
ed908a3 to
ab05574
Compare
ohmayr
approved these changes
Jul 23, 2026
hebaalazzeh
force-pushed
the
compact-layer
branch
from
July 24, 2026 00:04
ab05574 to
03fade5
Compare
hebaalazzeh
force-pushed
the
compact-layer
branch
from
July 24, 2026 00:06
03fade5 to
d50470c
Compare
ohmayr
approved these changes
Jul 24, 2026
hebaalazzeh
enabled auto-merge (squash)
July 24, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates the common code into a temporary compatibility layer as a fallback implementation as we move this code to google-api-core. Once, the minimum supported version of google-api-core has these functions we will clean up this layer.
Towards: #17883