fix(auth): properly extract stdout from gnubby webauthn plugin failures#17885
Open
macastelaz wants to merge 4 commits into
Open
fix(auth): properly extract stdout from gnubby webauthn plugin failures#17885macastelaz wants to merge 4 commits into
macastelaz wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the webauthn handler to manually handle non-zero exit statuses from the plugin subprocess, allowing for more detailed error reporting. The feedback points out that unconditionally stripping the first four bytes of stdout can corrupt plain-text error messages, and suggests verifying if the unpacked length matches the remaining bytes before stripping.
macastelaz
force-pushed
the
fix-webauthn-swallowed-errors
branch
from
July 23, 2026 21:45
0d45360 to
cb03c15
Compare
macastelaz
marked this pull request as ready for review
July 23, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: b/534311894