fix(bigframes): escape backtick in ordering_clause identifier#17837
Open
Samin061 wants to merge 1 commit into
Open
fix(bigframes): escape backtick in ordering_clause identifier#17837Samin061 wants to merge 1 commit into
Samin061 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ordering_clause function in bigframes/core/sql/__init__.py to escape special characters, such as backticks, in column names to prevent SQL injection or syntax errors. It also adds corresponding unit tests in tests/unit/core/test_sql.py to verify the escaping behavior. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ordering_clausedrops the column id straight into a backtick-quoted identifier without escaping, so a column name that contains a backtick closes the identifier early and the trailing text is parsed as SQL and run under the reader's BigQuery credentials. The SELECT compile path and this module's ownidentifier()helper already escape names withescape_chars, so the ORDER BY term now goes through the same escaping.