Skip to content

chore(bigquery): fix timeout flakiness in job tests #17826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chalmerlowe wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −8
Open

chore(bigquery): fix timeout flakiness in job tests #17826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/google-cloud-bigquery/tests/unit/job/test_async_job_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@
from unittest import mock

import google.api_core.retry
import google.cloud.bigquery.job
from google.api_core import exceptions

from . import helpers
import google.cloud.bigquery.job


PROJECT = "test-project"
JOB_ID = "test-job-id"
Expand Down Expand Up @@ -110,7 +109,7 @@ def test_result_w_retry_wo_state(global_time_lock):
predicate=custom_predicate,
initial=0.001,
maximum=0.001,
deadline=0.1,
deadline=1.0,
)
assert job.result(retry=custom_retry) is job

Expand Down
8 changes: 3 additions & 5 deletions packages/google-cloud-bigquery/tests/unit/job/test_query_job_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import concurrent.futures
from unittest import mock

import concurrent.futures
import freezegun
from google.api_core import exceptions
import google.api_core.retry
import pytest

from google.api_core import exceptions
from google.cloud.bigquery.client import _MIN_GET_QUERY_RESULTS_TIMEOUT
from google.cloud.bigquery.job import QueryJob
from google.cloud.bigquery.retry import DEFAULT_GET_JOB_TIMEOUT
Expand All @@ -27,7 +26,6 @@
from ..helpers import make_connection
from .helpers import _make_client


PROJECT = "test-project"
JOB_ID = "test-job-id"
QUERY = "select count(*) from persons"
Expand Down Expand Up @@ -105,7 +103,7 @@ def test_result_w_custom_retry(global_time_lock):
initial=0.001,
maximum=0.001,
multiplier=1.0,
deadline=0.1,
deadline=1.0,
predicate=custom_predicate,
)

Expand Down
Loading