Skip to content

feat(google/cloud/agentidentitycredentials/v1beta): add new v1beta1 version#17823

Open
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:onboard-new-library-2026-07-22-google/cloud/agentidentitycredentials/v1beta
Open

feat(google/cloud/agentidentitycredentials/v1beta): add new v1beta1 version#17823
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:onboard-new-library-2026-07-22-google/cloud/agentidentitycredentials/v1beta

Conversation

@suztomo

@suztomo suztomo commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Generated v1beta1 version for the existing google-cloud-agentidentitycredentials library.

suztomo@suztomo:~/librarian-2026/google-cloud-python$ go run github.com/googleapis/librarian/cmd/librarian@${V} add "${API_PATH}"
suztomo@suztomo:~/librarian-2026/google-cloud-python$ git diff
diff --git a/librarian.yaml b/librarian.yaml
index 58d7547d317..ec0609a6428 100644
--- a/librarian.yaml
+++ b/librarian.yaml
@@ -290,6 +290,7 @@ libraries:
     version: 0.1.0
     apis:
       - path: google/cloud/agentidentitycredentials/v1
+      - path: google/cloud/agentidentitycredentials/v1beta
     copyright_year: "2026"
     python:
       default_version: v1
diff --git a/release-please-bulk-config.json b/release-please-bulk-config.json
index 57ebae116c4..c5b6b2c0ee4 100644
--- a/release-please-bulk-config.json
+++ b/release-please-bulk-config.json
@@ -267,10 +267,16 @@
       "extra-files": [
         "google/cloud/agentidentitycredentials/gapic_version.py",
         "google/cloud/agentidentitycredentials_v1/gapic_version.py",
+        "google/cloud/agentidentitycredentials_v1beta/gapic_version.py",
         {
           "jsonpath": "$.clientLibrary.version",
           "path": "samples/generated_samples/snippet_metadata_google.cloud.agentidentitycredentials.v1.json",
           "type": "json"
+        },
+        {
+          "jsonpath": "$.clientLibrary.version",
+          "path": "samples/generated_samples/snippet_metadata_google.cloud.agentidentitycredentials.v1beta.json",
+          "type": "json"
         }
       ]
     },
suztomo@suztomo:~/librarian-2026/google-cloud-python$ docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo \
  docker.io/library/librarian-python:${V}  generate -v google-cloud-agentidentitycredentials
...

@suztomo
suztomo requested review from a team as code owners July 22, 2026 13:20
@snippet-bot

snippet-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the v1beta version of the google-cloud-agentidentitycredentials client library, including its generated services, types, transports, documentation, and samples. Feedback on the changes points out that a duplicate API Reference header was added to the documentation index, which could cause Sphinx build warnings, and suggests merging the new version's services and types under the existing toctree.

Comment thread packages/google-cloud-agentidentitycredentials/docs/index.rst
Comment on lines 16 to +24

API Reference
-------------
.. toctree::
:maxdepth: 2

agentidentitycredentials_v1beta/services_
agentidentitycredentials_v1beta/types_

@gemini-code-assist gemini-code-assist Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of a second API Reference header creates a duplicate section in the documentation, which can cause Sphinx build warnings or errors. Instead of creating a new section, the v1beta services and types should be listed under the existing toctree of the main API Reference section.

Suggested change
API Reference
-------------
.. toctree::
:maxdepth: 2
agentidentitycredentials_v1beta/services_
agentidentitycredentials_v1beta/types_
agentidentitycredentials_v1beta/services_
agentidentitycredentials_v1beta/types_

@suztomo

suztomo commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

unittest / unit (3.13) (pull_request) is failing.

...
        if hasattr(google.auth.transport.mtls, "should_use_client_cert"):
            for config_data, expected_cert_source in test_cases:
                env = os.environ.copy()
                env.pop("GOOGLE_API_USE_CLIENT_CERTIFICATE", None)
                with mock.patch.dict(os.environ, env, clear=True):
                    config_filename = "mock_certificate_config.json"
                    config_file_content = json.dumps(config_data)
                    m = mock.mock_open(read_data=config_file_content)
                    with mock.patch("builtins.open", m):
                        with mock.patch.dict(
                            os.environ, {"GOOGLE_API_CERTIFICATE_CONFIG": config_filename}
                        ):
                            mock_api_endpoint = "foo"
                            options = client_options.ClientOptions(
                                client_cert_source=mock_client_cert_source,
                                api_endpoint=mock_api_endpoint,
                            )
                            api_endpoint, cert_source = (
                                client_class.get_mtls_endpoint_and_cert_source(options)
                            )
                            assert api_endpoint == mock_api_endpoint
>                           assert cert_source is expected_cert_source
E                           AssertionError: assert None is <Mock id='140028694900960'>

tests/unit/gapic/agentidentitycredentials_v1beta/test_auth_provider_credentials_service.py:1080: AssertionError
_ test_auth_provider_credentials_service_client_get_mtls_endpoint_and_cert_source[AuthProviderCredentialsServiceAsyncClient] _

@suztomo

suztomo commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

The command to reproduce the failure:

(venv) suztomo@suztomo:~/librarian-2026/google-cloud-python$ pytest packages/google-cloud-agentidentitycredentials/tests/unit/ -k test_auth_provider_credentials_service_client_get_mtls_endpoint_and_cert_source

@suztomo

suztomo commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

It seems the failure is not limited to this module being created.

@suztomo

suztomo commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

#17807 mentioned an updated generator template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@suztomo