chore: fix bigtable authorized view routing#17707
Draft
chalmerlowe wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the system tests in test_system_async.py and test_system_autogen.py to use self.target._request_path instead of self.target.table_name when constructing requests for adding rows, adding aggregate rows, and deleting rows. It also cleans up and reorders imports in both files. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bigtable system tests were failing with timeout errors (
DeadlineExceeded) when testing Authorized Views because a test helper (TempRowBuilder) was hardcoded to only use the table name, ignoring the view identifier.Solution
Updated the test helper in the Bigtable package to dynamically use either the table name or the authorized view name depending on the test target by utilizing the internal
_request_pathproperty. This ensures requests are routed correctly to the intended target.Notes to Reviewers
Note
Changes in the
test_system_autogen.pyfile are auto-generated viaCrossSyncand are simply synchronous versions of the async tests intest_system_async.py. Comments related to the content oftest_system_async.pywill be automatically added totest_system_autogen.py