fix(api_core): clarify misleading http 404 unimplemented error message#17681
Open
guptaarima wants to merge 1 commit into
Open
fix(api_core): clarify misleading http 404 unimplemented error message#17681guptaarima wants to merge 1 commit into
guptaarima wants to merge 1 commit into
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
Context:
When a gRPC call fails with grpc.StatusCode.UNIMPLEMENTED but the error details string includes "Received http2 header with status: 404", the google-api-core library currently translates this into google.api_core.exceptions.MethodNotImplemented. This scenario often happens due to client-side configuration errors like an incorrect api_endpoint or a malformed resource path, not because the method is actually unimplemented.
Actual Behavior:
The library raises google.api_core.exceptions.MethodNotImplemented: 501 Received http2 header with status: 404. This exception is misleading because the primary issue indicated by the underlying error is related to the 404 (Not Found), not that the method is unimplemented (501). This makes debugging difficult for users.
Expected Behavior:
google-api-core should raise an exception that better reflects the underlying HTTP 404. Suggested improvements:
Prioritize the 404 status when present in the details, raising google.api_core.exceptions.NotFound (404).
Alternatively, consider google.api_core.exceptions.ServiceUnavailable (503) if the context strongly suggests the endpoint is wrong.
The goal is to provide a more actionable error message to the user, guiding them to check the endpoint or resource path.