Skip to content

chore(generator): use absolute paths in __lazy_modules__ #17614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hebaalazzeh merged 3 commits into from
Jul 2, 2026
Merged

chore(generator): use absolute paths in __lazy_modules__ #17614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b7a8a1
feat: implement native PEP 0810 lazy loading with absolute paths
hebaalazzeh Jul 1, 2026
13c40f3
update goldens
hebaalazzeh Jul 1, 2026
1888d4b
update goldens
hebaalazzeh Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/__init__.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ from importlib import metadata
__lazy_modules__ = {
{% filter sort_lines -%}
{% for subpackage, _ in api.subpackages|dictsort -%}
f"{__name__}.{{ subpackage }}",
"{{package_path}}.{{ subpackage }}",
{% endfor -%}
{% for service in api.services.values()
if service.meta.address.subpackage == api.subpackage_view -%}
f"{__name__}.services.{{ service.name|snake_case }}",
"{{package_path}}.services.{{ service.name|snake_case }}",
{% endfor -%}
{% for proto in api.protos.values()
if proto.meta.address.subpackage == api.subpackage_view -%}
f"{__name__}.types.{{ proto.module_name }}",
"{{package_path}}.types.{{ proto.module_name }}",
{% endfor -%}
{% endfilter %}
}
Expand Down
8 changes: 4 additions & 4 deletions packages/gapic-generator/tests/integration/goldens/asset/google/cloud/asset_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.asset_service",
f"{__name__}.types.asset_enrichment_resourceowners",
f"{__name__}.types.asset_service",
f"{__name__}.types.assets",
"google.cloud.asset_v1.services.asset_service",
"google.cloud.asset_v1.types.asset_enrichment_resourceowners",
"google.cloud.asset_v1.types.asset_service",
"google.cloud.asset_v1.types.assets",
}

@daniel-sanche daniel-sanche Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, but it seems like these strings should probably be indented

@hebaalazzeh hebaalazzeh Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed



Expand Down
6 changes: 3 additions & 3 deletions ...pic-generator/tests/integration/goldens/credentials/google/iam/credentials_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.iam_credentials",
f"{__name__}.types.common",
f"{__name__}.types.iamcredentials",
"google.iam.credentials_v1.services.iam_credentials",
"google.iam.credentials_v1.types.common",
"google.iam.credentials_v1.types.iamcredentials",
}


Expand Down
26 changes: 13 additions & 13 deletions ...s/gapic-generator/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.eventarc",
f"{__name__}.types.channel",
f"{__name__}.types.channel_connection",
f"{__name__}.types.discovery",
f"{__name__}.types.enrollment",
f"{__name__}.types.eventarc",
f"{__name__}.types.google_api_source",
f"{__name__}.types.google_channel_config",
f"{__name__}.types.logging_config",
f"{__name__}.types.message_bus",
f"{__name__}.types.network_config",
f"{__name__}.types.pipeline",
f"{__name__}.types.trigger",
"google.cloud.eventarc_v1.services.eventarc",
"google.cloud.eventarc_v1.types.channel",
"google.cloud.eventarc_v1.types.channel_connection",
"google.cloud.eventarc_v1.types.discovery",
"google.cloud.eventarc_v1.types.enrollment",
"google.cloud.eventarc_v1.types.eventarc",
"google.cloud.eventarc_v1.types.google_api_source",
"google.cloud.eventarc_v1.types.google_channel_config",
"google.cloud.eventarc_v1.types.logging_config",
"google.cloud.eventarc_v1.types.message_bus",
"google.cloud.eventarc_v1.types.network_config",
"google.cloud.eventarc_v1.types.pipeline",
"google.cloud.eventarc_v1.types.trigger",
}


Expand Down
14 changes: 7 additions & 7 deletions ...ges/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.config_service_v2",
f"{__name__}.services.logging_service_v2",
f"{__name__}.services.metrics_service_v2",
f"{__name__}.types.log_entry",
f"{__name__}.types.logging",
f"{__name__}.types.logging_config",
f"{__name__}.types.logging_metrics",
"google.cloud.logging_v2.services.config_service_v2",
"google.cloud.logging_v2.services.logging_service_v2",
"google.cloud.logging_v2.services.metrics_service_v2",
"google.cloud.logging_v2.types.log_entry",
"google.cloud.logging_v2.types.logging",
"google.cloud.logging_v2.types.logging_config",
"google.cloud.logging_v2.types.logging_metrics",
}


Expand Down
14 changes: 7 additions & 7 deletions ...-generator/tests/integration/goldens/logging_internal/google/cloud/logging_v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.config_service_v2",
f"{__name__}.services.logging_service_v2",
f"{__name__}.services.metrics_service_v2",
f"{__name__}.types.log_entry",
f"{__name__}.types.logging",
f"{__name__}.types.logging_config",
f"{__name__}.types.logging_metrics",
"google.cloud.logging_v2.services.config_service_v2",
"google.cloud.logging_v2.services.logging_service_v2",
"google.cloud.logging_v2.services.metrics_service_v2",
"google.cloud.logging_v2.types.log_entry",
"google.cloud.logging_v2.types.logging",
"google.cloud.logging_v2.types.logging_config",
"google.cloud.logging_v2.types.logging_metrics",
}


Expand Down
4 changes: 2 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.cloud_redis",
f"{__name__}.types.cloud_redis",
"google.cloud.redis_v1.services.cloud_redis",
"google.cloud.redis_v1.types.cloud_redis",
}


Expand Down
4 changes: 2 additions & 2 deletions ...pic-generator/tests/integration/goldens/redis_selective/google/cloud/redis_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.cloud_redis",
f"{__name__}.types.cloud_redis",
"google.cloud.redis_v1.services.cloud_redis",
"google.cloud.redis_v1.types.cloud_redis",
}


Expand Down
6 changes: 3 additions & 3 deletions ...gration/goldens/storagebatchoperations/google/cloud/storagebatchoperations_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
# https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
# Older Python versions safely ignore this variable.
__lazy_modules__ = {
f"{__name__}.services.storage_batch_operations",
f"{__name__}.types.storage_batch_operations",
f"{__name__}.types.storage_batch_operations_types",
"google.cloud.storagebatchoperations_v1.services.storage_batch_operations",
"google.cloud.storagebatchoperations_v1.types.storage_batch_operations",
"google.cloud.storagebatchoperations_v1.types.storage_batch_operations_types",
}


Expand Down
Loading