fix(auth): lower regional access boundary logs from warning to info.#17571
Open
nbayati wants to merge 1 commit into
Open
fix(auth): lower regional access boundary logs from warning to info.#17571nbayati wants to merge 1 commit into
nbayati wants to merge 1 commit into
Conversation
When the library tries to look up Regional Access Boundaries in the background and fails, it used to print a "WARNING" message. Because these lookups are optional and failing is not considered fatal or blocking, omitting warnings creates a lot of log noise for the users. This change lowers those messages to the "INFO" level so they stay out of the way by default.
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes various Regional Access Boundary (RAB) lookup log messages from warning to info level and updates the test suite to verify this behavior. The reviewer pointed out that promoting the successful lookup log from DEBUG to INFO increases log noise for the happy path, which contradicts the goal of reducing noise, and suggested keeping it at DEBUG.
| ) | ||
| if _helpers.is_logging_enabled(_LOGGER): | ||
| _LOGGER.debug("Regional Access Boundary lookup successful.") | ||
| _LOGGER.info("Regional Access Boundary lookup successful.") |
Contributor
There was a problem hiding this comment.
This change promotes the successful lookup log from DEBUG to INFO, which increases log noise for the happy path. Since the goal of this PR is to reduce log noise, successful lookups should remain at the DEBUG level.
Suggested change
| _LOGGER.info("Regional Access Boundary lookup successful.") | |
| _LOGGER.debug("Regional Access Boundary lookup successful.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the library tries to look up Regional Access Boundaries in the background and fails, it used to print a "WARNING" message. Because these lookups are optional and failing is not considered fatal or blocking, omitting warnings creates a lot of log noise for the users. This change lowers those messages to the "INFO" level so they stay out of the way by default.
fixes #17515