Skip to content

fix(bigtable): populate Value type in _format_execute_query_view_params #17547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutianf merged 7 commits into from
Jun 24, 2026
+5 −1
Merged

fix(bigtable): populate Value type in _format_execute_query_view_params #17547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e86716
fix: ensure Value object type is set to string in _format_execute_que…
ad548 Jun 23, 2026
5f35bf2
refactor: leverage _convert_value_to_pb_value_dict in _format_execute…
ad548 Jun 24, 2026
265fddf
test: address PR review comments by using to_dict for proto-plus mess…
ad548 Jun 24, 2026
a986d81
style: format _convert_value_to_pb_value_dict call to conform to 88-c…
ad548 Jun 24, 2026
cd6b201
style: format test assertions and test files for Ruff formatting comp…
ad548 Jun 24, 2026
47a1aa9
style: use local variable in type assertions to guarantee stable form…
ad548 Jun 24, 2026
ad6c589
style: revert broad formatting changes in test_client.py to keep Ruff…
ad548 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _format_execute_query_view_params(
raise TypeError(
f"View parameter {key} must be a string, got {type(value).__name__}"
)
result_values[key] = Value(string_value=value)
result_values[key] = _convert_value_to_pb_value_dict(value, SqlType.String())

return result_values

Expand Down
2 changes: 2 additions & 0 deletions packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3558,6 +3558,8 @@ async def test_execute_query_with_view_parameters(
request = execute_query_mock.call_args[0][0]
assert "user_id" in request.view_parameters
assert request.view_parameters["user_id"].string_value == "alice"
val_type = request.view_parameters["user_id"].type_
assert type(val_type).to_dict(val_type) == {"string_type": {}}

@CrossSync.pytest
async def test_execute_query_with_view_parameters_invalid_type(
Expand Down
2 changes: 2 additions & 0 deletions packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3019,6 +3019,8 @@ def test_execute_query_with_view_parameters(
request = execute_query_mock.call_args[0][0]
assert "user_id" in request.view_parameters
assert request.view_parameters["user_id"].string_value == "alice"
val_type = request.view_parameters["user_id"].type_
assert type(val_type).to_dict(val_type) == {"string_type": {}}

def test_execute_query_with_view_parameters_invalid_type(
self, client, execute_query_mock, prepare_mock
Expand Down
Loading