chore(bigtable): fix flaky sharded query concurrency limit test by relaxing eps#17541
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test_mutations_batcher_flush_interval unit test to mock threading.Timer instead of using time.sleep, which speeds up the test execution. The reviewer noted that manually invoking the timer callback and asserting mocked_flush.assert_called_once_with() is redundant because the callback is already the mocked_flush mock itself, and suggested removing these redundant assertions.
parthea
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky tests:
test_read_rows_sharded_concurrency_limitwas flaky under VM execution load because it checked if all of the first 10 concurrent requests were dispatched withineps = 0.01seconds (10 milliseconds) of the operation's start.Due to CPU scheduling and thread context switching overhead on virtualized CI hosts (like Kokoro), dispatching 10 concurrent threads/tasks can occasionally take slightly longer than 10ms, triggering random
AssertionErrorfailures.Solution:
epsfrom0.01to0.2seconds (200 milliseconds) in:This allows enough scheduling margin for virtualized CI runners to pass successfully while still validating that the first 10 queries are fired concurrently without delay compared to the queued queries.