Skip to content

chore: re-generate all#17505

Open
zhumin8 wants to merge 1 commit into
googleapis:mainfrom
zhumin8:check-regenerate
Open

chore: re-generate all#17505
zhumin8 wants to merge 1 commit into
googleapis:mainfrom
zhumin8:check-regenerate

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Re-generate all in attempt to restore repo to "clean" state where config in librarian.yaml and generated code matches.

Run below commands.

V=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version)
go run github.com/googleapis/librarian/tool/cmd/builddockerimages@latest --language python --version=${V} 
docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo docker.io/library/librarian-python:${V}  generate -v --all

Fixes #17426, #17427
For googleapis/librarian#6450

@zhumin8 zhumin8 requested a review from a team as a code owner June 18, 2026 01:21
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README to explicitly list Python <= 3.9 as unsupported and cleans up the import statements in leaser.py by reordering them. There are no review comments, so I have no feedback to provide.

@zhumin8 zhumin8 mentioned this pull request Jun 18, 2026
Open
@zhumin8

zhumin8 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Direct cause of generation diff is from https://github.com/googleapis/google-cloud-python/pull/17485/changes
@chalmerlowe unfortunately the removal you made to packages/google-cloud-pubsub/README.rst is re-written back. Since this is generated, I think you need to edit the template if this is universal to libraries? Otherwise, I am not sure if python supports handwritten or partials in readme?
Let's keep the generated version for now.

@zhumin8 zhumin8 enabled auto-merge (squash) June 18, 2026 02:02
@zhumin8 zhumin8 mentioned this pull request Jun 18, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea Awaiting requested review from parthea

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

@ohmayr ohmayr Awaiting requested review from ohmayr

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regeneration check found diff

1 participant

@zhumin8