Revert "chore(generator): centralize mypy configuration and regenerate google-cloud-datastore POC"#17493
Conversation
…e google…" This reverts commit 8ea802d.
There was a problem hiding this comment.
Code Review
This pull request transitions from a centralized mypy configuration to package-specific mypy.ini files across generator templates and golden packages. It also lowers the minimum version requirements for several dependencies in google-cloud-datastore (such as google-api-core, proto-plus, and protobuf) and updates the corresponding version checks and constraints. Feedback on the changes includes a correction to a regular expression in setup.py where unescaped dots are acting as wildcards instead of matching literal dots.
| r"(?<=\")\d+\.\d+\.\d+[^\"\s]*(?=\")", | ||
| fp.read(), | ||
| ) | ||
| version_candidates = re.findall(r"(?<=\")\d+.\d+.\d+(?=\")", fp.read()) |
There was a problem hiding this comment.
The regular expression \d+.\d+.\d+ contains unescaped dots (.), which act as wildcards matching any character instead of literal dots. This could lead to incorrect version parsing if the version file contains other characters. Please escape the dots as \..
| version_candidates = re.findall(r"(?<=\")\d+.\d+.\d+(?=\")", fp.read()) | |
| version_candidates = re.findall(r"(?<=\")\d+\.\d+\.\d+(?=\")", fp.read()) |
Reverts #17408