Skip to content

chore(bigquery): add dynamic logging banner to nox mypy session #17492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −1
Draft

chore(bigquery): add dynamic logging banner to nox mypy session #17492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf4224
feat(bigquery): add dynamic logging banner to nox mypy session
chalmerlowe Jun 17, 2026
042e991
style(bigquery): update package name derivation in log_package_context
chalmerlowe Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/google-cloud-bigquery/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@

from __future__ import absolute_import

import contextlib
from functools import wraps
import os
import pathlib
from typing import Generator
import re
import shutil
import time
Expand Down Expand Up @@ -80,6 +82,25 @@ def wrapper(*args, **kwargs):
]


@contextlib.contextmanager
def log_package_context(session: nox.Session) -> Generator[None, None, None]:
"""Logs a highly visible package context banner right before a session exits.

Ensures metadata is printed adjacent to Nox's final status log,
even if the session fails or raises an exception.
"""
# Dynamically extract current folder name (e.g., 'google-cloud-bigquery')
package_name = CURRENT_DIRECTORY.name

try:
# Hands control back to the session code block
yield
finally:
# This executes AFTER test output finishes, immediately above Nox's summary line
banner_text = f"Finished session for {package_name.lower()}"
session.log(banner_text)


def default(session, install_extras=True):
"""Default unit test session.

Expand Down Expand Up @@ -193,7 +214,8 @@ def mypy(session):
"types-setuptools",
)
session.run("python", "-m", "pip", "freeze")
session.run("mypy", "-p", "google", "--show-traceback")
with log_package_context(session):
session.run("mypy", "-p", "google", "--show-traceback")


@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
Expand Down
Loading