chore(firestore): remove named database duplication in system tests#17442
Open
ohmayr wants to merge 2 commits into
Open
chore(firestore): remove named database duplication in system tests#17442ohmayr wants to merge 2 commits into
ohmayr wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes the system test suite by removing the named database (FIRESTORE_OTHER_DB) from the global TEST_DATABASES list to eliminate test duplication. Instead, the named database is now explicitly parameterized only for the test_document_get test cases in both synchronous and asynchronous system tests to verify path routing. I have no feedback to provide as the changes are clean and well-documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces system test execution time by removing redundant test sweeps across identical standard databases.