chore: update librarian to v0.16.1-0.20260608172125-d123ec9cac76#17398
Merged
suztomo merged 2 commits intoJun 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the librarian version and removes the pytest-xdist dependency and its corresponding -n auto execution flags from the noxfile.py configuration. However, in setup.py, the entire test extra was removed instead of only removing pytest-xdist. The reviewer points out that this could break installations relying on .[test] and suggests retaining the other test dependencies.
| "pytest-xdist", | ||
| ], | ||
| } | ||
| extras = {"libcst": "libcst >= 0.2.5"} |
Contributor
There was a problem hiding this comment.
The test extra has been completely removed from extras. If this package is installed with .[test] in CI or by developers, this change will break those installations. If the goal was only to remove pytest-xdist, please retain the other test dependencies.
Suggested change
| extras = {"libcst": "libcst >= 0.2.5"} | |
| extras = { | |
| "libcst": "libcst >= 0.2.5", | |
| "test": [ | |
| "pytest", | |
| "mock", | |
| "asyncmock", | |
| "pytest-cov", | |
| "pytest-asyncio", | |
| ], | |
| } |
noahdietz
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7611ac7#diff-464bebf2dae71c02c30ec0ece355447da9494ccd906ffd3127e3efb9a7c50fcf reverted the pseudo version change somehow. Let's use the pseudo version to unblock google.cloud.agentidentitycredentials.v1 library generation (b/520427993).