chore(bigtable): add bigtable samples#17240
Open
daniel-sanche wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive collection of Python samples for Google Cloud Bigtable, covering synchronous and asynchronous APIs, Apache Beam integration, HappyBase compatibility, and administrative operations. The review feedback highlights several critical improvements for the robustness of these samples, such as adding null checks for row lookups to prevent AttributeError or KeyError, and correcting the usage of await with async iterables. Other recommendations include adopting UTC timestamps for consistency, using more idiomatic Python for result counting, and implementing defensive checks for monitoring queries to handle empty results without raising exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding back hand-written samples to python-bigtable
There is an argument that these samples should live in https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main, but I think it's best to keep the generated and hand-written samples together for now. And then we can revisit this again after splitting the admin and data surfaces. Let me know if you disagree