feat: regenerate google-maps packages#17073
Conversation
TODO: release notes here
There was a problem hiding this comment.
Code Review
This pull request updates multiple Google Maps Python packages to drop support for Python 3.9, setting the minimum requirement to Python 3.10. Key changes include updating copyright headers to 2026, bumping dependency versions for google-api-core and grpcio, and removing legacy compatibility logic for older Python versions. Additionally, async call patterns in routeoptimization samples were corrected and test assertions were updated to handle non-deterministic parameter ordering. Review feedback identified a formatting error in a docstring within route_optimization_service.py and requested the restoration of the -W flag in noxfile.py to maintain consistent documentation build standards across the repository.
| The ratio (vehicle_end_time - vehicle_start_time) / (latest_vehicle_end_time - earliest_vehicle_start_time) for a given vehicle. If the denominator is not present, it uses ([ShipmentModel.global_end_time][google.maps.routeoptimization.v1.ShipmentModel.global_end_time] | ||
| ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| [ShipmentModel.global_start_time][google.maps.routeoptimization.v1.ShipmentModel.global_start_time]) | ||
| instead. |
There was a problem hiding this comment.
This docstring appears to have a formatting error. The subtraction operator - is missing, and a long line of dashes has been inserted, making the description of the fallback calculation incorrect. Please correct the docstring to reflect the subtraction.
| The ratio (vehicle_end_time - vehicle_start_time) / (latest_vehicle_end_time - earliest_vehicle_start_time) for a given vehicle. If the denominator is not present, it uses ([ShipmentModel.global_end_time][google.maps.routeoptimization.v1.ShipmentModel.global_end_time] | |
| ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | |
| [ShipmentModel.global_start_time][google.maps.routeoptimization.v1.ShipmentModel.global_start_time]) | |
| instead. | |
| The ratio (vehicle_end_time - vehicle_start_time) / (latest_vehicle_end_time - earliest_vehicle_start_time) for a given vehicle. If the denominator is not present, it uses | |
| ([ShipmentModel.global_end_time][google.maps.routeoptimization.v1.ShipmentModel.global_end_time] - | |
| [ShipmentModel.global_start_time][google.maps.routeoptimization.v1.ShipmentModel.global_start_time]) | |
| instead. |
| @@ -390,7 +389,6 @@ def docs(session): | |||
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | |||
| session.run( | |||
| "sphinx-build", | |||
There was a problem hiding this comment.
The -W flag, which treats Sphinx warnings as errors, was removed from the sphinx-build command. Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests. Please revert this change to maintain consistency across the repository.
| "sphinx-build", | |
| "sphinx-build", | |
| "-W", # warnings as errors |
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions. ## Changes - Removed Python <=3.9 from testing, configuration, and constraints files. - Resolved dependency conflicts arising from dropping Python <=3.9 support. - Cleaned up obsolete code related to Python <=3.9 support. - Updated select copyright dates - Updated some autogenerated headings - Updated some tests to resolve issues discovered during this migration.
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions.
Changes