feat: regenerate google-shopping packages#17072
Conversation
TODO: release notes here
There was a problem hiding this comment.
Code Review
This pull request performs a broad update across multiple Google Shopping packages, including advancing copyright years to 2026, dropping Python 3.9 support, and increasing dependency lower bounds. Unit tests were simplified by removing legacy compatibility imports and coverage pragmas, while REST test assertions were improved with parameter sorting. Feedback points out a documentation rendering regression caused by the removal of code block markers in the merchant reports package, the inconsistent removal of the warnings-as-errors flag in the CSS package's build configuration, and a missing dependency in the merchant notifications constraints file.
| Free listings \| Shopping ads \| Status | ||
| --------------\|--------------\|------------------------------ | ||
| Approved \| Approved \| ELIGIBLE Approved \| Pending \| ELIGIBLE | ||
| Approved \| Disapproved \| ELIGIBLE_LIMITED Pending \| Pending \| | ||
| PENDING Disapproved \| Disapproved \| NOT_ELIGIBLE_OR_DISAPPROVED |
There was a problem hiding this comment.
The code block markers (backticks) have been removed from this example table. Furthermore, the table rows appear to be corrupted and merged into single lines (e.g., line 758 contains what should be two separate rows). This will likely prevent the documentation from rendering correctly. Please verify the generator logic for this table.
| "sphinx-build", | ||
| "-W", # warnings as errors | ||
| "-T", # show full traceback on exception |
There was a problem hiding this comment.
The -W flag has been removed from the sphinx-build command. This flag is important for maintaining documentation quality as it treats warnings as errors, ensuring that any formatting or reference issues are caught during the build process. Please consider restoring it, as changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
session.run(
"sphinx-build",
"-W", # warnings as errors
"-T", # show full traceback on exceptionReferences
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
| google-api-core==2.17.1 | ||
| google-auth==2.14.1 | ||
| grpcio==1.44.0 | ||
| proto-plus==1.22.3 | ||
| protobuf==4.25.8 |
There was a problem hiding this comment.
google-shopping-type==1.0.0 is missing from this constraints file, even though it is listed as a dependency in setup.py. Constraints files should include all primary dependencies to ensure that lower-bound compatibility checks are accurate during testing.
google-api-core==2.17.1
google-auth==2.14.1
grpcio==1.44.0
proto-plus==1.22.3
protobuf==4.25.8
google-shopping-type==1.0.0
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions. ## Changes - Removed Python <=3.9 from testing, configuration, and constraints files. - Resolved dependency conflicts arising from dropping Python <=3.9 support. - Cleaned up obsolete code related to Python <=3.9 support. - Updated select copyright dates - Updated some autogenerated headings - Updated some tests to resolve issues discovered during this migration.
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions.
Changes