chore: adjust string replacements for gapic-generator 1.32.0#17042
chore: adjust string replacements for gapic-generator 1.32.0#17042jskeet wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates dependency version requirements for google-api-core and grpcio across multiple post-processing configuration files, removes legacy replacement rules for constraints files, and deletes several obsolete configuration files. Feedback suggests correcting a potential version mismatch in a replacement block within storage-integration.yaml and cautions against removing version pins in constraints files, as this may lead to non-deterministic build environments.
| "grpc": [ | ||
| "google-api-core[grpc] >= 2.27.0, < 3.0.0", | ||
| "grpcio >= 1.33.2, < 2.0.0; python_version < '3.14'", | ||
| "grpcio >= 1.44.0, < 2.0.0; python_version < '3.14'", |
There was a problem hiding this comment.
The before block for the grpc dependencies replacement has been updated to grpcio >= 1.44.0, but the corresponding after block (not shown in this hunk but part of the same replacement) likely still contains the old version 1.33.2. This will cause the post-processing to either fail to match or, if it matches, to incorrectly downgrade the version in the generated setup.py. Please ensure the after block is also updated to match the new version.
| google-auth | ||
| # cryptography is a direct dependency of google-auth | ||
| cryptography | ||
| google-api-core==2.27.0 | ||
| google-cloud-core==2.4.2 | ||
| google-resumable-media==2.7.2 | ||
| grpcio==1.33.2 | ||
| requests==2.22.0 | ||
| google-crc32c==1.6.0 | ||
| protobuf==4.25.8 | ||
| opentelemetry-api==1.1.0 | ||
| google-api-core | ||
| google-cloud-core | ||
| google-resumable-media | ||
| grpcio | ||
| requests | ||
| google-crc32c | ||
| protobuf | ||
| opentelemetry-api |
There was a problem hiding this comment.
The after block for the constraints-*.txt replacements has been updated to remove all version pins (e.g., google-auth, google-api-core). Constraints files are typically expected to have pinned versions to ensure reproducible and stable test environments. Removing these pins might lead to non-deterministic builds or CI failures if incompatible transitive dependencies are pulled in.
Given that similar constraints replacements were removed entirely from other integration files in this PR, consider if this replacement is still necessary or if it should maintain pinned versions.
Note: this PR does not regenerate anything; if we merge it, I would expect an issue to be created as regeneration with the current generator in librarian (1.30.13) will fail. That's fine if it's planned as part of the process of updating the generator, but it's important to be aware of.