refactor(bigframes): Introduce GoogleSqlScalarOp#17037
Open
TrevorBergeron wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces GoogleSqlScalarOp to provide a more direct mapping between BigFrames operations and GoogleSQL functions, refactoring several geography and mathematical operations to use this new infrastructure. It also adds support for omitted optional arguments across the expression and compilation layers for both Ibis and sqlglot. Feedback identifies several critical implementation errors in the Ibis compiler registry, including incorrect list methods, return type mismatches, and logic errors in argument indexing. Additionally, there are issues with missing imports, incorrect type hints, and consistent typos in the 'omitted' property across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕