chore: add bigframes load test config to the kokoro configs#17035
Open
sycai wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new build script and Kokoro configuration for load testing the bigframes package. Feedback includes a critical correction to the artifact cleanup process to avoid deleting test logs, a fix for a potential script failure when grepping environment variables under 'set -e', and a recommendation to avoid hardcoding the Vertex AI endpoint to improve configuration flexibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are pulled from the old BigFrames repo:
We will also add configs to pipers so that the BigFrames load test will have its own dedicated Kokoro job.
Internal issue: b/509623551