feat: add generation of existing version of googleads resumable upload#17031
feat: add generation of existing version of googleads resumable upload#17031viacheslav-rostovtsev wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for resumable uploads within the GAPIC generator, specifically targeting the Google Ads API. The changes include adding properties to the schema wrappers to identify resumable methods, updating client templates to handle binary streams, and implementing new transport templates to manage the resumable upload protocol and associated error handling. Feedback from the reviewer highlights significant architectural concerns regarding the hardcoding of Google Ads-specific logic, imports, and parameters into shared, general-purpose templates and schema wrappers. Additionally, the reviewer identified a bug where unit tests do not align with the current implementation, and suggested improvements for error handling by avoiding base exceptions and magic numbers.
This enables Resumable Upload ("Scotty") features generation for Google Ads "Simply" libraries only.
Briefly the changes consist of three parts:
Full description of the changes in the internal document go/cloudsdk-scotty-python-q226 .