-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(sqlalchemy-bigquery): add mypy session and resolve type errors #17030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chalmerlowe
wants to merge
6
commits into
main
Choose a base branch
from
feat/add-mypy-sqlalchemy-16014
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
77d15e7
fix(sqlalchemy-bigquery): update literal binds test for SQLAlchemy 2.0
chalmerlowe e99039b
test(sqlalchemy-bigquery): update test to use exec_driver_sql per review
chalmerlowe 7dc1782
feat(sqlalchemy-bigquery): add mypy session and configuration
chalmerlowe 7f5727e
fix(sqlalchemy-bigquery): resolve type errors in helpers, struct, and…
chalmerlowe a145644
fix(sqlalchemy-bigquery): resolve type errors in base.py
chalmerlowe 719ca76
test(sqlalchemy-bigquery): fix NullType instantiation in test_catalog…
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
| ignore_missing_imports = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True | ||
|
|
||
| # Optional dependency for GIS/spatial support. Lacks type hints. | ||
| [mypy-geoalchemy2.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| # Optional dependency used by geoalchemy2. Lacks type hints. | ||
| [mypy-shapely.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| # Optional dependency for database migrations. Lacks type hints. | ||
| [mypy-alembic.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| # Obsolete package checked in __init__.py only to warn users that it is not supported | ||
| # and that they should use sqlalchemy-bigquery instead. Not installed. | ||
| [mypy-pybigquery.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| # TODO(https://github.com/googleapis/gapic-generator-python/issues/2563): | ||
| # Dependencies that historically lacks py.typed markers | ||
| [mypy-google.iam.*] | ||
| ignore_missing_imports = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for assigning
client_infoappears to be incorrect and introduces a regression.google_client_info(typically an alias forgoogle.api_core.gapic_v1.client_info.ClientInfo) is a class that should be instantiated to return aClientInfoobject. The original codegoogle_client_info(user_agent=user_agent)correctly handled bothNoneand string values foruser_agentto produce a validClientInfoinstance. The new code assigns the rawuser_agentstring toclient_infowhen it is notNone, which will cause anAttributeErrorwhenbigquery.Clientattempts to accessClientInfomethods (such asto_user_agent()) on what is now a string object.