feat(storage): support delete_source_objects in compose API#17015
feat(storage): support delete_source_objects in compose API#17015nidhiii-27 wants to merge 2 commits into
Conversation
Implements the delete_source_objects parameter in Blob.compose() to allow automatic deletion of source objects upon successful composition. Reference PR: googleapis/google-cloud-java#12873 Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request introduces the delete_source_objects parameter to the Blob.compose method, allowing source objects to be automatically deleted after a successful composition. The changes include updates to the method signature, docstrings, and request payload construction, along with a new unit test to verify the functionality. I have no feedback to provide.
Implements the delete_source_objects parameter in Blob.compose() to allow automatic deletion of source objects upon successful composition. Also adds unit and system tests to verify the new parameter. Reference PR: googleapis/google-cloud-java#12873 Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
This PR adds support for the
delete_source_objectsparameter in theBlob.composemethod of thegoogle-cloud-storagepackage. This aligns the Python SDK with feature parity in the Java SDK.Key changes:
Blob.composesignature to acceptdelete_source_objects.Blob.composedocstring.deleteSourceObjectsin the JSON request body sent to the GCS REST API.test_compose_w_delete_source_objectstotest_blob.pyto verify correct serialization.Blobpass.PR created automatically by Jules for task 5220279067164674388 started by @nidhiii-27