fix(spanner_dbapi): replace insecure pickle with json for partition deserialization#17014
Open
sinhasubham wants to merge 1 commit into
Open
fix(spanner_dbapi): replace insecure pickle with json for partition deserialization#17014sinhasubham wants to merge 1 commit into
sinhasubham wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the use of pickle with json for serializing and deserializing partition IDs to mitigate security risks associated with insecure deserialization. It introduces _serialize_value and _deserialize_value helper functions to handle specific types like bytes, datetime, and protobuf messages. Review feedback points out that MessageToDict defaults to camelCase, which could break compatibility with code expecting snake_case, and suggests using preserving_proto_field_name=True. Additionally, the reviewer noted that protobuf messages are currently deserialized as dictionaries rather than original message objects, which may lead to issues with nested field types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a critical Insecure Deserialization vulnerability (potential Remote Code Execution) in the
spanner_dbapimodule b/510871112 . Previously, the module utilizedpickle.loads()to decode partition IDs provided by users via theRUN PARTITIONstatement, creating a possibility for arbitrary code execution attack payloads.We have fully eliminated
pickleusage in this module and migrated to standardjsonserialization.