Conversation
There was a problem hiding this comment.
Code Review
This pull request enables mypy type checking by adding a dedicated nox session and applying type suppression comments across the codebase. The review feedback highlights several areas where type safety can be improved beyond simple suppression, such as correctly initializing the base class in core.py, declaring internal methods as class attributes, and fixing an invalid type hint for na_value. It is also suggested to remove the broad --ignore-missing-imports flag from the mypy configuration to avoid masking potential environment issues.
| values = values.copy() | ||
|
|
||
| super().__init__(values=values, dtype=values.dtype) | ||
| super().__init__(values=values, dtype=values.dtype) # type: ignore[call-arg] |
There was a problem hiding this comment.
The call-arg error indicates that the base class's __init__ does not accept these arguments. If the base class is ExtensionArray or PandasObject, it should be called without arguments.
| super().__init__(values=values, dtype=values.dtype) # type: ignore[call-arg] | |
| super().__init__() |
Giving pd.NAType a try instead of Any to see if that passes. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR enables the mypy session in noxfile.py for db-dtypes and aligns it with the GAPIC generator template. It passes with some type ignores added for missing stubs and internal pandas usage.