chore: complete google-cloud-runtimeconfig migration#16670
Open
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Open
chore: complete google-cloud-runtimeconfig migration#16670jskeet wants to merge 2 commits intogoogleapis:mainfrom
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
jskeet
commented
Apr 16, 2026
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the repository metadata for google-cloud-runtimeconfig and applies various formatting changes to imports across the package, including reordering and adjusting whitespace. A review comment suggests restoring a blank line between imports in _http.py to maintain consistency with PEP 8 and other files in the project.
Comment on lines
19
to
20
| from google.cloud import _http | ||
|
|
||
| from google.cloud.runtimeconfig import __version__ |
Contributor
There was a problem hiding this comment.
For consistency with other files in this package (such as config.py and variable.py) and to adhere to PEP 8 grouping rules, there should be a blank line between the external google.cloud import and the local google.cloud.runtimeconfig import.
Suggested change
| from google.cloud import _http | |
| from google.cloud.runtimeconfig import __version__ | |
| from google.cloud import _http | |
| from google.cloud.runtimeconfig import __version__ |
References
- PEP 8 suggests that imports should be grouped in the following order: standard library imports, related third party imports, local application/library specific imports. Each group of imports should be separated by a blank line. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.