chore: complete google-cloud-pubsub migration#16669
Open
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Open
chore: complete google-cloud-pubsub migration#16669jskeet wants to merge 2 commits intogoogleapis:mainfrom
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
jskeet
commented
Apr 16, 2026
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
Contributor
Author
|
@parthea Please check that the index.rst change looks okay to you. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the metadata and documentation for the Google Cloud Pub/Sub library, including reordering fields in .repo-metadata.json, updating documentation links, and reorganizing imports in the client files. A redundant entry for summary_overview.md was found in the documentation index, which could lead to build warnings.
Comment on lines
+39
to
+42
| .. toctree:: | ||
| :hidden: | ||
|
|
||
| summary_overview.md |
Contributor
There was a problem hiding this comment.
The summary_overview.md file is already included in the toctree on lines 35-37. Adding it again here is redundant and will cause Sphinx build warnings regarding duplicate document entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.