test(spanner): update mock server tests to check for inline begin#16656
Merged
test(spanner): update mock server tests to check for inline begin#16656
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the create_engine method in the mock server test base to use NullPool, which disables connection pooling and ensures that a new session is created for every test. I have no feedback to provide as there were no review comments to evaluate.
olavloite
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
sqlalchemy-spannermock server tests to account for the dialect now inliningBeginTransactionrequests into the first statement execution.Changes
BeginTransactionRequestwhere applicable.transaction.beginoptions.These changes resolve the off-by-one failures in request counts across multiple mock server tests.